An open source Valkey client library that supports Valkey and Redis open source 6.2, 7.0 and 7.2. Valkey GLIDE is designed for reliability, optimized performance, and high-availability, for Valkey and Redis OSS based applications. GLIDE is a multi language client library, written in Rust with programming language bindings, such as Java and Python
Apache License 2.0
241
stars
53
forks
source link
Rust: unmaintained dependencies need updating #2239
proc-macro-error is used in glide-core and is deemed to be unmaintained and should be replaced with proc-macro-error2. There are other dependencies that use proc-macro-error as well like iai-callgrind-macros, dispose-derive, etc. Some of the dependencies have also been inactive for years and needs replacing before this error occurs again.
Error:
error[unmaintained]: proc-macro-error is unmaintained
┌─ /home/runner/work/valkey-glide/valkey-glide/java/Cargo.lock:105:1
│
105 │ proc-macro-error 1.0.4 registry+https://github.com/rust-lang/crates.io-index
│ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ unmaintained advisory detected
│
├ ID: RUSTSEC-2024-0370
├ Advisory: https://rustsec.org/advisories/RUSTSEC-2024-0370
├ proc-macro-error's maintainer seems to be unreachable, with no commits for 2 years, no releases pushed for 4 years, and no activity on the GitLab repo or response to email.
proc-macro-error also depends on `syn 1.x`, which may be bringing duplicate dependencies into dependant build trees.
## Possible Alternative(s)
- [proc-macro-error2](https://crates.io/crates/proc-macro-error2)
├ Announcement: https://gitlab.com/CreepySkeleton/proc-macro-error/-/issues/20
├ Solution: No safe upgrade is available!
├ proc-macro-error v1.0.4
└── dispose-derive v0.4.0
└── dispose v0.5.0
├── glide-core v0.1.0
│ └── glide-rs v0.1.0
└── redis v0.25.2
├── glide-core v0.1.0 (*)
└── glide-rs v0.1.0 (*)
Expected Behavior
All dependencies should be from maintained projects to prevent this error from reoccuring.
Current Behavior
Running cargo deny check advisories --config ../deny.toml outputs the error error[unmaintained]: proc-macro-error is unmaintained.
Reproduction Steps
Remove "RUSTSEC-2024-0370" from the ignore block in deny.toml file.
Run cd glide-core
Run cargo deny check advisories --config ../deny.toml
Describe the bug
proc-macro-error
is used inglide-core
and is deemed to be unmaintained and should be replaced withproc-macro-error2
. There are other dependencies that useproc-macro-error
as well like iai-callgrind-macros, dispose-derive, etc. Some of the dependencies have also been inactive for years and needs replacing before this error occurs again.Error:
Expected Behavior
All dependencies should be from maintained projects to prevent this error from reoccuring.
Current Behavior
Running
cargo deny check advisories --config ../deny.toml
outputs the errorerror[unmaintained]: proc-macro-error is unmaintained
.Reproduction Steps
"RUSTSEC-2024-0370"
from the ignore block in deny.toml file.cd glide-core
cargo deny check advisories --config ../deny.toml
Possible Solution
No response
Additional Information/Context
From https://github.com/valkey-io/valkey-glide/pull/2235#issuecomment-2332907525:
Once the issue is resolved, please revert changes on deny.toml in https://github.com/valkey-io/valkey-glide/pull/2235.
Request to update
iai-callgrind
sproc-macro-error
dependency: https://github.com/iai-callgrind/iai-callgrind/issues/262Client version used
1.0.1
Engine type and version
N/A
OS
macOS
Language
Rust
Language Version
cargo 1.79.0
Cluster information
No response
Logs
No response
Other information
No response