Node: Add release artefact to the IT test framework

valkey-io / valkey-glide

An open source Valkey client library that supports Valkey and Redis open source 6.2, 7.0 and 7.2. Valkey GLIDE is designed for reliability, optimized performance, and high-availability, for Valkey and Redis OSS based applications. GLIDE is a multi language client library, written in Rust with programming language bindings, such as Java and Python

Apache License 2.0

268 stars 56 forks source link

Node: Add release artefact to the IT test framework #2316

Open yipin-chen opened 2 months ago

yipin-chen commented 2 months ago

Describe the feature

In Node, currently IT tests are tested against development package. However, while testing release artefact, we observed few missing exports, issue 2307. To prevent this, we need to properly add the release artefact to the IT test frame so this doesn't happen again. We should be able to catch these bugs during PR development.

Use Case

We should be able to catch these bugs during PR development.

Proposed Solution

No response

Other Information

No response

Acknowledgements

[ ] I may be able to implement this feature request
[ ] This feature might incur a breaking change

Client version used

1.1

Environment details (OS name and version, etc.)

Mac

avifenesh commented 2 months ago

Let's make it for all languages — the implementation needs to be the following: For each CI tests run we add another job which run with one lang and engine version, and one host, build and pack the package without publishing then run IT tests and release tests against it.

@adarovadya it will solve your wish to test the release tests frequently. @Yury-Fridlyand How is it sound as a solution instead of make it part of the release itself?

Yury-Fridlyand commented 2 months ago

Sorry, I don't understand what do you mean in

release tests against it

acarbonetto commented 2 months ago

Let's make it for all languages — the implementation needs to be the following: For each CI tests run we add another job which run with one lang and engine version, and one host, build and pack the package without publishing then run IT tests and release tests against it.

@adarovadya it will solve your wish to test the release tests frequently. @Yury-Fridlyand How is it sound as a solution instead of make it part of the release itself?

We need this for Node and Python. Java is already release tested - although we don't run the entire IT test suite against the releasable artefact (also, there isn't really any reason to do that for Java).

avifenesh commented 2 months ago

Sorry, I don't understand what do you mean in

release tests against it

That's less relevant for what you wanted, @adarovadya wanted general testing of the release tests for knowing it's not broken at release time.