search

valkey-io / valkey-glide

An open source Valkey client library that supports Valkey and Redis open source 6.2, 7.0 and 7.2. Valkey GLIDE is designed for reliability, optimized performance, and high-availability, for Valkey and Redis OSS based applications. GLIDE is a multi language client library, written in Rust with programming language bindings, such as Java and Python
Apache License 2.0
227 stars 49 forks source link

Python/Node: Define which Symbols are part of the client API #2335

Open acarbonetto opened 5 days ago

acarbonetto commented 5 days ago

Describe the feature

As part of 1.1 release, we were unable to determine which Symbols are part of the glide client API and which Symbols do not need to be exported as part of the client release.

Ideally, this is defined clearly in the design of the client.

Use Case

see issue https://github.com/valkey-io/valkey-glide/issues/2332

Proposed Solution

No response

Other Information

No response

Acknowledgements

Client version used

1.1

Environment details (OS name and version, etc.)

N/A

acarbonetto commented 3 days ago

Potential Proposed solution for Node: All API types should be NamedSpaced (see: GlideClientConfiguration and GlideClusterClientConfiguration). All types in namespaces are exported as part of NativeBindings and don't need to be individually specified in the npm/glide/index.ts re-package.