Node: Ensure client closure in flushAndCloseClient with try-finally - Githubissues

valkey-io / valkey-glide

An open source Valkey client library that supports Valkey and Redis open source 6.2, 7.0 and 7.2. Valkey GLIDE is designed for reliability, optimized performance, and high-availability, for Valkey and Redis OSS based applications. GLIDE is a multi language client library, written in Rust with programming language bindings, such as Java and Python

Apache License 2.0

268 stars 56 forks source link

Node: Ensure client closure in flushAndCloseClient with try-finally #2614

Closed jhpung closed 2 weeks ago

jhpung commented 2 weeks ago

Clients may not be properly closed when FLUSHALL command times out in flushAndCloseClient, despite being handled in afterEach blocks of test suites.

The issue is reproducible by configuring an extremely low random requestTimeout value in ClientConfiguration during testTeardown execution

Fixes CI: https://github.com/avifenesh/valkey-glide/actions/runs/11678481691/job/32518075011

Issue link

This Pull Request is linked to issue (URL): https://github.com/valkey-io/valkey-glide/issues/2336

Checklist

Before submitting the PR make sure the following are checked:

[x] This Pull Request is related to one issue.
[x] Commit message has a detailed description of what changed and why.
[x] Tests are added or updated.
[ ] CHANGELOG.md and documentation files are updated.
[x] Destination branch is correct - main or release
[x] Commits will be squashed upon merging.