An open source Valkey client library that supports Valkey and Redis open source 6.2, 7.0 and 7.2. Valkey GLIDE is designed for reliability, optimized performance, and high-availability, for Valkey and Redis OSS based applications. GLIDE is a multi language client library, written in Rust with programming language bindings, such as Java and Python
This pull request is centered around setting an option to replace the password configured for connection.
The feature introduced the need for major changes in the core functionality of the core, and introduced a new platform in the core for performing management operation on the cluster connection.
The pull request includes various updates and improvements across different parts of the codebase, including workflow updates, dependency changes, and enhancements to the server connection handling. The most important changes include adding support for replacing connection passwords, updating dependencies, and introducing a builder pattern for MultiplexedConnection.
Workflow Updates:
.github/workflows/python.yml: Added pip install -r dev_requirements.txt to ensure development dependencies are installed before running tests. [1][2]
This PR is a great cooperation between the greatest @jhpung, the one and only @umit, and myself, and created a ton of joy of working together as a team.
Issue link
This Pull Request is linked to issue: #2360
To-Do:
[x] Protobuf message for the interaction of the new API which is different from CMD API – @avifenesh
[x] Node.js binding implementation and tests — @jhpung
[x] Python binding implementation and tests — @avifenesh
[x] Java binding implementation and tests — @acarbonetto Do we have someone with the capacity to take it, or support me when I'm struggling around?
[x] Go binding and tests — @umit
[x] Changelog — @avifenesh
[ ] General docs section — @avifenesh
Checklist
Before submitting the PR make sure the following are checked:
[x] This Pull Request is related to one issue.
[x] Commit message has a detailed description of what changed and why.
[x] Tests are added or updated.
[x] CHANGELOG.md and documentation files are updated.
[x] Destination branch is correct - main or release
This pull request is centered around setting an option to replace the password configured for connection. The feature introduced the need for major changes in the core functionality of the core, and introduced a new platform in the core for performing management operation on the cluster connection.
The pull request includes various updates and improvements across different parts of the codebase, including workflow updates, dependency changes, and enhancements to the server connection handling. The most important changes include adding support for replacing connection passwords, updating dependencies, and introducing a builder pattern for
MultiplexedConnection
.Workflow Updates:
.github/workflows/python.yml
: Addedpip install -r dev_requirements.txt
to ensure development dependencies are installed before running tests. [1] [2]Dependency Updates:
glide-core/redis-rs/redis/Cargo.toml
: Updated Rust version from 1.65 to 1.67 and removedfast-math
dependency. [1] [2] [3]Changelog Updates:
CHANGELOG.md
: Added an entry for the new feature that supports replacing connection passwords for multiple languages.Server Connection Enhancements:
glide-core/redis-rs/redis/src/aio/multiplexed_connection.rs
: Introduced a builder pattern forMultiplexedConnection
, added a method to update the connection password, and madePipeline
struct public within the crate. [1] [2] [3] [4] [5] [6] [7]glide-core/redis-rs/redis/src/cluster_async/mod.rs
: Added support for updating the connection password across all cluster servers and improved error handling. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]Typo Fixes:
glide-core/redis-rs/redis/src/cluster.rs
: Fixed typos in comments. [1] [2]This PR is a great cooperation between the greatest @jhpung, the one and only @umit, and myself, and created a ton of joy of working together as a team.
Issue link
This Pull Request is linked to issue: #2360
To-Do:
Checklist
Before submitting the PR make sure the following are checked: