Node: Improve writeOrBufferCommandRequest for better maintainability

valkey-io / valkey-glide

An open source Valkey client library that supports Valkey and Redis open source 6.2, 7.0 and 7.2. Valkey GLIDE is designed for reliability, optimized performance, and high-availability, for Valkey and Redis OSS based applications. GLIDE is a multi language client library, written in Rust with programming language bindings, such as Java and Python

Apache License 2.0

268 stars 56 forks source link

Description

As this function requires additional conditional statements with each new command, leading to increased complexity, we should consider a new structure to reduce this complexity.

https://github.com/valkey-io/valkey-glide/pull/2651#discussion_r1836452388

Problems

Growing complexity with each new command type
Single function handling too many responsibilities

Checklist

[ ] Review all current command types and their handling patterns
[ ] Explore alternative approaches or improvements to replace/enhance the current function.
[ ] Write tests to ensure the new implementation maintains existing functionality.

Additional Notes

No response

valkey-io / valkey-glide