Node: add AZ Affinity ReadFrom strategy Support

valkey-io / valkey-glide

An open source Valkey client library that supports Valkey and Redis open source 6.2, 7.0 and 7.2. Valkey GLIDE is designed for reliability, optimized performance, and high-availability, for Valkey and Redis OSS based applications. GLIDE is a multi language client library, written in Rust with programming language bindings, such as Java and Python

Apache License 2.0

265 stars 55 forks source link

Node: add AZ Affinity ReadFrom strategy Support #2686

Closed Muhammad-awawdi-amazon closed 2 days ago

Muhammad-awawdi-amazon commented 1 week ago

Issue link

This Pull Request is linked to issue (URL): #643

Checklist

Before submitting the PR make sure the following are checked:

[x] This Pull Request is related to one issue.
[x] Commit message has a detailed description of what changed and why.
[x] Tests are added or updated.
[x] CHANGELOG.md and documentation files are updated.
[x] Destination branch is correct - main or release
[x] Commits will be squashed upon merging.

avifenesh commented 1 week ago

Some comments. For the testing logic i will let @adarovadya review and approve. I know some of my questions might be relevant to Adar and not to you directly, feel free to tell her to address it.

adarovadya commented 2 days ago

Please add Change.log comment. see example - https://github.com/valkey-io/valkey-glide/pull/2676/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edR2