valkey-io / valkey-glide

An open source Valkey client library that supports Valkey and Redis open source 6.2, 7.0 and 7.2. Valkey GLIDE is designed for reliability, optimized performance, and high-availability, for Valkey and Redis OSS based applications. GLIDE is a multi language client library, written in Rust with programming language bindings, such as Java and Python
Apache License 2.0
268 stars 56 forks source link

Allow cluster wide scan with not fully covered cluster #2689

Open avifenesh opened 1 week ago

avifenesh commented 1 week ago

This pull request includes several changes to the glide-core/redis-rs/redis module, primarily focusing on refactoring and improving the cluster_scan functionality. The most important changes involve modifying the cluster_scan method, updating error handling, and enhancing test coverage.

Refactoring and improvements to cluster_scan:

Error handling improvements:

Test coverage enhancements:

These changes collectively improve the maintainability, error handling, and test coverage of the cluster_scan functionality in the glide-core/redis-rs/redis module.

Issue link

This Pull Request is linked to issue #2436

Checklist

Before submitting the PR make sure the following are checked:

Yury-Fridlyand commented 6 days ago

I propose to split into multipe PRs - for core and per-client changes to avoid troubles like we had with another feature

avifenesh commented 6 days ago

I propose to split into multipe PRs - for core and per-client changes to avoid troubles like we had with another feature

Will do core+python for full integration prof, will move node to another.

Note that the changes to binding are almost not existent, mainly tests.