Open avifenesh opened 1 week ago
I propose to split into multipe PRs - for core and per-client changes to avoid troubles like we had with another feature
I propose to split into multipe PRs - for core and per-client changes to avoid troubles like we had with another feature
Will do core+python for full integration prof, will move node to another.
Note that the changes to binding are almost not existent, mainly tests.
This pull request includes several changes to the
glide-core/redis-rs/redis
module, primarily focusing on refactoring and improving thecluster_scan
functionality. The most important changes involve modifying thecluster_scan
method, updating error handling, and enhancing test coverage.Refactoring and improvements to
cluster_scan
:glide-core/redis-rs/redis/src/cluster_async/mod.rs
: Removed thecluster_scan_with_pattern
method and merged its functionality into thecluster_scan
method, which now accepts aClusterScanArgs
struct containing all necessary arguments. [1] [2]glide-core/redis-rs/redis/src/commands/mod.rs
: AddedClusterScanArgs
to the list of public exports for thecluster-async
feature. [1] [2]Error handling improvements:
glide-core/redis-rs/redis/src/cluster_async/mod.rs
: Enhanced error messages in themap_err
andunwrap_or_else
closures to provide more context about the errors encountered during command execution. [1] [2]Test coverage enhancements:
glide-core/redis-rs/redis/tests/test_async_cluster_connections_logic.rs
: Updated test cases to include theaz
field inConnectionDetails
and ensure comprehensive testing of connection logic. [1] [2] [3] [4] [5] [6]glide-core/redis-rs/redis/tests/test_cluster_scan.rs
: Modified thetest_async_cluster_scan
andtest_async_cluster_scan_with_migration
tests to use theTestClusterContext::new_with_cluster_client_builder
method and the updatedcluster_scan
method withClusterScanArgs
. [1] [2] [3] [4]These changes collectively improve the maintainability, error handling, and test coverage of the
cluster_scan
functionality in theglide-core/redis-rs/redis
module.Issue link
This Pull Request is linked to issue #2436
Checklist
Before submitting the PR make sure the following are checked: