Closed stockholmux closed 1 month ago
Do you have a suggested way to review this?
@madolson Yeah, there are so many deletes in this PR it makes difficult to break it down.
Probably best to just look at my fork/branch. The README shows how to preview the site in total (visually it's 99% identical to the existing site except with all docs exposed).
The most relevant directories are /build/
which contains a few initialization scripts, and /templates/
which contains the majority of the 'logic' (if you can call it that). The bits are very similar what was on the Jekyll side, just jumbled around or changed slightly (yaml
to toml
, etc.)
FYI - this is very much a work in progress. There are a few changes that happened while I was porting the site that I need to re-integrate and the linking needs a few tweaks. I'm having a few folks try it out and give me feedback about the DX.
When running it locally, I don't get the valkey logo in the title like valkey.io currently:
. I just see Valkey.
Markdown has looks a bit weird:
compared to
Not sure what the long term is, but it looked a bit better before.
Not a major issue, but it looks like we aren't rendering images correctly from docs/topics. http://127.0.0.1:1111/docs/topics/lru_comparison.png just gives a generic error.
Ok, I clicked through all the links I could find and everything else looks good to me.
@madolson I figured out the poor syntax highlighting. Looks like I was missing some recommended styles for the built-in syntax highlighting scheme.
This also solves some weird container overflow problems. It still uses the light-on-dark (which I prefer for code blocks), but I think it's possible to make it dark-on-light if you feel strongly.
@stockholmux That looks fine to me, the problem was the lack of padding and the weird overflowing you observed. The proposal you have LGTM.
Created an issue documenting all of the files that still need to be reviewed: https://github.com/valkey-io/valkey-doc/issues/91
@madolson when you say "would rather merge it and work incrementally on smaller diffs" are you asking me to abandon this PR and do it in multiple PRs?
No I'm saying merge it! We can followup with anything that is missing.
Description
This changes valkey.io from Jekyll to Zola and adds all documentation topic pages.
Sorry for the big bang there isn't a graceful way to do this in git.
Path forward to Zola in production
jekyll-version
)config.extra.review_list
array.valkey-io/valkey-doc
should be created at the same to address the content bits.Issues Resolved
Fixes #62
Check List
--signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.