search

valkey-io / valkey-py

Valkey Python client based on a fork of redis-py
MIT License
69 stars 9 forks source link

cluster connection exception #109

Closed amirreza8002 closed 1 month ago

amirreza8002 commented 1 month ago

hi i belive this error should have been valkey.exception.ConnectionError to be consistent with other clients

aiven-sal commented 1 month ago

What do you mean by "with other clients"? That exception can also be raised if the nodes don't support cluster mode, so I think that the somewhat generic ValkeyClusterException is the most appropriate, the message will include details about the specific reason anyway.

I'm also not very keen on changing things that can break user code without a very strong reason.