valkey-io / valkey-py

Valkey Python client based on a fork of redis-py
MIT License
21 stars 2 forks source link

adds protocol support for `redis` and `rediss` #27

Open kjaymiller opened 4 days ago

kjaymiller commented 4 days ago

Pull Request check-list

Please make sure to review and check all of these items:

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

resolves #26 #23

codecov-commenter commented 4 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (main@d116aa6). Learn more about missing BASE report.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #27 +/- ## ======================================= Coverage ? 75.05% ======================================= Files ? 131 Lines ? 34386 Branches ? 0 ======================================= Hits ? 25807 Misses ? 8579 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kjaymiller commented 3 days ago
  1. could you squash the lint changes in your second commit in the first one? It would make it easier for me to review commit-by-commit.

I hope I did this correctly