Please make sure to review and check all of these items:
[ ] Do tests and lints pass with this change?
[ ] Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
[ ] Is the new or changed code fully tested?
[ ] Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
[ ] Is there an example added to the examples folder (if applicable)?
[ ] Was the change added to CHANGES file?
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Created url_parser and removed duplication of parse_url. This PR resolves issue #25
I created a url_parser module and added it to the parsers folder. I then used this module in both connection modules (the normal one and the asyncio one) and updated the tests accordingly.
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Created url_parser and removed duplication of parse_url. This PR resolves issue #25
I created a url_parser module and added it to the parsers folder. I then used this module in both connection modules (the normal one and the asyncio one) and updated the tests accordingly.