Open ahmedsobeh opened 2 days ago
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Created url_parser and removed duplication of parse_url. This PR resolves issue https://github.com/valkey-io/valkey-py/issues/25
I created a url_parser module and added it to the parsers folder. I then used this module in both connection modules (the normal one and the asyncio one) and updated the tests accordingly.
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Created url_parser and removed duplication of parse_url. This PR resolves issue https://github.com/valkey-io/valkey-py/issues/25
I created a url_parser module and added it to the parsers folder. I then used this module in both connection modules (the normal one and the asyncio one) and updated the tests accordingly.