Closed mkmkme closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 75.12%. Comparing base (
b10b338
) to head (798569b
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Previously integration tests invoked
sleep 10
to "give time to settle" the environment. In a fast container, waiting for so long is not needed and in a slow one it might not be enough.This commit changes this line to use
./util/wait-for-it.sh
instead [1] to check robustly that the port is being listened to.Fixes #49.
[1] https://github.com/vishnubob/wait-for-it
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Please provide a description of the change here.