valkey-io / valkey-py

Valkey Python client based on a fork of redis-py
MIT License
69 stars 9 forks source link

github: replace call for sleep with wait-for-it.sh #81

Closed mkmkme closed 2 months ago

mkmkme commented 2 months ago

Previously integration tests invoked sleep 10 to "give time to settle" the environment. In a fast container, waiting for so long is not needed and in a slow one it might not be enough.

This commit changes this line to use ./util/wait-for-it.sh instead [1] to check robustly that the port is being listened to.

Fixes #49.

[1] https://github.com/vishnubob/wait-for-it

Pull Request check-list

Please make sure to review and check all of these items:

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.12%. Comparing base (b10b338) to head (798569b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #81 +/- ## ======================================= Coverage 75.11% 75.12% ======================================= Files 132 132 Lines 34397 34400 +3 ======================================= + Hits 25837 25842 +5 + Misses 8560 8558 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.