search

valkey-io / valkey-py

Valkey Python client based on a fork of redis-py
MIT License
71 stars 9 forks source link

incompatiable code with redis py #82

Closed amirreza8002 closed 2 months ago

amirreza8002 commented 2 months ago

hi so i want to fork django-redis package and turn into django-valkey this parts of redis_py package is not available in your project. some parts of it are used in django-redis so i was wondering if there is a reason why these are not presented.

Version: latest

aiven-sal commented 2 months ago

Hi Amirreza! Thanks for reaching out. Since when the fork happened, valkey-py and redis-py diverged a little bit. They are still very similar, but they are also evolving independently. I think that the code you are looking for is now here: https://github.com/valkey-io/valkey-py/blob/fd7a56a8b9abcabe1f2b1e148244b8fcc7db4382/valkey/_parsers/url_parser.py#L14-L100

amirreza8002 commented 2 months ago

oh thanks it makes sense i was assuming that the projects go exactly the same way for the moment

I'll fix the import then

aiven-sal commented 2 months ago

No problem, feel free to re-open this issue if you encounter any other problem.

amirreza8002 commented 2 months ago

hello @aiven-sal i wanted to know what version of python are you supporting? i have some typing headaches coming from valkey_py and wanted to write a patch need to know what syntax i can and can't use

aiven-sal commented 2 months ago

We support from 3.8 to 3.12 (https://github.com/valkey-io/valkey-py/blob/main/setup.py#L50-L54), BTW there is another issue related to typing you if you want to take a look https://github.com/valkey-io/valkey-py/issues/84

amirreza8002 commented 2 months ago

ah i was hoping for 3.10 to use | :)

ok then

also i know you are busy but if you ever find the time to reflect on django-valkey i would very much appreciate it I'm new to caching and still trying to figure out stuff

aiven-sal commented 2 months ago

ah i was hoping for 3.10 to use | :)

I think it will probably take a couple of years before we drop 3.9. :(

also i know you are busy but if you ever find the time to reflect on django-valkey i would very much appreciate it I'm new to caching and still trying to figure out stuff

What do you mean by "reflect on django-valkey" ?

amirreza8002 commented 2 months ago

ah i just meant feedback on what can be added or fixed on the project which i just realize i hadn't posted the link before django-valkey

but again i understand that it's not a small codebase and you are busy, so don't feel pressure

aiven-sal commented 2 months ago

I'm not very much involved in django development. I'd suggest to reach out to the original django-redis's devs. They might have some feedback and they may be even interested in cooperating on django-valkey.