valkey-io / valkey-py

Valkey Python client based on a fork of redis-py
MIT License
69 stars 9 forks source link

Make valkey-py install the correct dependencies in Python 3.11.0 to Python 3.11.3 #92

Closed nirav-ark-biotech closed 2 months ago

nirav-ark-biotech commented 2 months ago

I just happened to be using Python 3.11.1 while using valkey-py.

The PR #87 broke my CI/CD pipeline (when upgrading to valkey-py 6.1 bc the codebase, in https://github.com/valkey-io/valkey-py/blob/03320e6b2720a90d1b2ac7946d82bdc4d87f3faa/valkey/asyncio/connection.py#L31

just so happens to check whether or not we're 3.11.3 and above.

If you are in Python 3.11.0 - 3.11.2, you go into the else and this code fails if async timeout is not installed

so we need to still to install async-timeout if python version < 3.11.3

Pull Request check-list

Description of change

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.12%. Comparing base (03320e6) to head (0f8b7c0).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #92 +/- ## ======================================= Coverage 75.12% 75.12% ======================================= Files 132 132 Lines 34398 34398 ======================================= Hits 25840 25840 Misses 8558 8558 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

aiven-sal commented 2 months ago

Hi! Thanks for reporting and apologies for the inconvenience. I think that setup.py would also need to be updated. I'll add a commit here for that, so we can make a new release quickly

nirav-ark-biotech commented 2 months ago

Great, thanks all!