[BUG] Is hiredis using outdated Openssl initialization calls?

[bentotten]

Describe the bug

Unsure if this is a significant issue, however I am looking at this commit: https://github.com/valkey-io/valkey/commit/3881f7850f9f81720315bd4f33f2f9dedcc242bb

where SSL_library_init(); is tucked behind a version flag for openssl, however noticed that hiredis still uses this call and does not appear to have a version flag:

https://github.com/valkey-io/valkey/blob/a62d1f177b7888ec88035a0a1ce600fbc2280ce7/deps/hiredis/ssl.c#L170

Was this intentional?

To reproduce

N/A

Expected behavior

N/A

Additional information

• [redis 7.0.0 + openssl 3.0.1] https://github.com/redis/redis/issues/10711
• Redis 6.2.6 configure with openssl 3.0.1

[zuiderkwast]

It's possible we're using outdated APIs. I think none of us remember the OpenSSL API exactly. Can you please help explain what we do wrong and what we should do instead?

CC @bjosv