[BUG] `CLIENT REPLY OFF` in transaction handled incorrectly

[Yury-Fridlyand]

Describe the bug

Server returns malformed response.

127.0.0.1:7000> multi
OK
127.0.0.1:7000(TX)> ping before
QUEUED
127.0.0.1:7000(TX)> client reply off 
QUEUED
127.0.0.1:7000(TX)> ping 1
QUEUED
127.0.0.1:7000(TX)> ping 2
QUEUED
127.0.0.1:7000(TX)> client reply on
QUEUED
127.0.0.1:7000(TX)> ping after
QUEUED
127.0.0.1:7000(TX)> exec

Server replies with RESP array of declared size 6, but it contains only 2 elements: "before" and "after". That is correct to receive 2 elements, but size should be declared as 2. Wireshark helps to track this.

In case if transaction is "reply off; ; reply on; end", received RESP array is empty, but declared size reflects the number of commands.

See Wireshark screenshot:

To reproduce

See above

Expected behavior

Declared RESP array lenght should be valid (match number of elements in it, regardless of real transaction size)

Additional information

A low priority issue.

CLI tool also fails to process the response. Use Wireshark to see what happens on the wire.

[Yury-Fridlyand]

I'd like to do a fix for that if you can give me some guidelines on which files/classes to start with and how to debug the server.

[enjoy-binbin]

Thanks for the report. The place to look (and start) is execCommand, we need to modify array len based on the client flags. During the looking, i have fixed and verified it locally. Let me know if you need more infomation or need me to take over.