Open soloestoy opened 1 week ago
Attention: Patch coverage is 88.18898%
with 15 lines
in your changes missing coverage. Please review.
Project coverage is 70.71%. Comparing base (
2df56d8
) to head (03a6736
). Report is 18 commits behind head on unstable.
Files with missing lines | Patch % | Lines |
---|---|---|
src/commandlog.c | 92.79% | 8 Missing :warning: |
src/server.c | 57.14% | 3 Missing :warning: |
src/latency.c | 0.00% | 2 Missing :warning: |
src/module.c | 0.00% | 2 Missing :warning: |
🚨 Try these New Features:
Just for Note: Let's first refresh the memory in pr https://github.com/valkey-io/valkey/pull/336, the last comment conclusion is:
After a core team meeting, we decided adding a new command COMMANDLOG with subcommands HEAVYTRAFFIC and SLOW, and then slowlog.c can be renamed to a common commandlog.c. https://github.com/valkey-io/valkey/pull/336#issuecomment-2246809112
From my understanding, for the command: commandlog get should be: COMMANDLOG get count slow | heavytraffic-input | heavytraffic-output.
commandlog len should be: COMMANDLOG len slow | heavytraffic-input | heavytraffic-output.
commandlog reset should be: COMMANDLOG reset slow | heavytraffic-input | heavytraffic-output.
Can you describe the terms heavytraffic-input and heavytraffic-output in the json file (argument part) because I can only know them from the source codes and valkey.conf so far?
And I think the existing slowlog commands should be deprecated? If yes, I think you should update the related json files as well.
As discussed in PR #336.
We have different types of resources like CPU, memory, network, etc. The
slowlog
can only record commands eat lots of CPU during the processing phase (doesn't include read/write network time), but can not record commands eat too many memory and network. For example:This PR introduces a new command
COMMANDLOG
, to log commands that consume significant network bandwidth, including both input and output. Users can retrieve the results usingCOMMANDLOG get <count> large-request
andCOMMANDLOG get <count> large-reply
, all subcommands forCOMMANDLOG
are:COMMANDLOG HELP
COMMANDLOG GET <count> <slow|large-request|large-reply>
COMMANDLOG LEN <slow|large-request|large-reply>
COMMANDLOG RESET <slow|large-request|large-reply>
And the slowlog is also incorporated into the commandlog.