Skip reclaim file page cache test in valgrind

enjoy-binbin commented 2 days ago

The test is incompatible with valgrind. Added a new --valgrind argument to test suite, which will cause that test to be skipped.

We skipped it in the past, see https://github.com/valkey-io/valkey/commit/5b61b0dc6d2579ee484fa6cf29bfac59513f84ab.

enjoy-binbin commented 2 days ago

daily: https://github.com/enjoy-binbin/valkey/actions/runs/11928806942

codecov[bot] commented 2 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.70%. Comparing base (4986310) to head (aa027db). Report is 6 commits behind head on unstable.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## unstable #1327 +/- ## ============================================ + Coverage 70.68% 70.70% +0.01% ============================================ Files 115 115 Lines 63177 63171 -6 ============================================ + Hits 44657 44662 +5 + Misses 18520 18509 -11 ``` [see 11 files with indirect coverage changes](https://app.codecov.io/gh/valkey-io/valkey/pull/1327/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=valkey-io)

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles

zuiderkwast commented 1 day ago

FYI. This test case also fails for me locally on linux on macbook M2, without valgrind.

enjoy-binbin commented 1 day ago

FYI. This test case also fails for me locally on linux on macbook M2, without valgrind.

ok... so a fake linux will also fail, i don't have this env so i can not try.

zuiderkwast commented 1 day ago

It's not "fake linux" :rofl:

It is normal Linux compiled for Aarch64 with 16KB page size and 128B cache line size and

valkey-io / valkey

Skip reclaim file page cache test in valgrind #1327

Codecov Report