search

valkey-io / valkey

A flexible distributed key-value datastore that is optimized for caching and other realtime workloads.
https://valkey.io
Other
17.42k stars 656 forks source link

Request for Review of valkeyJSON Module #1354

Open roshkhatri opened 13 hours ago

roshkhatri commented 13 hours ago

I would like to request a review of the ValkeyJSON module for inclusion in the valkey-io organization. This module has been implemented based on the specifications detailed in the accepted RFC document: ValkeyJSON Specification.

The module is currently hosted in my repository: ValkeyJSON Repository.

Please let me know if any additional documentation, context, or changes are required to facilitate this review. I look forward to your feedback and the next steps toward integrating this module.

@valkey-io/core-team, your input would be greatly appreciated.

UPDATE: PR for contributing the valkeyJSON module: https://github.com/valkey-io/valkeyJSON/pull/1

Best regards, Roshan

PingXie commented 13 hours ago

Logistic questions. How do we comment on the doc and the code without a PR? :)

How about creating a repo under Valkey and cutting a PR?

roshkhatri commented 13 hours ago

Sure I will do that asap. Can you create a repo under valkey with the name of valkeyJSON so I can open a PR for it?

roshkhatri commented 13 hours ago

Wait I can do that