search

valkey-io / valkey

A new project to resume development on the formerly open-source Redis project. We're calling it Valkey, since it's a twist on the key-value datastore.
https://valkey.io
Other
14.66k stars 520 forks source link

Replace all "redis" keywords to "valkey" in tcl test files #155

Open hwware opened 3 months ago

hwware commented 3 months ago

In test tcl files, a lot of "redis" keywords represent server，for example

spawn_instance redis $::redis_base_port $::instances_count {
        "enable-protected-configs yes"
        "enable-debug-command yes"
        "save ''"
}

We would like to use other words to replace the "redis"

Note: 1.Do not touch the words such as "redis_version" because in the info command, we will still keep these output

  1. Do not change any RedisModule* words becuase we still want to keep it.
daniel-house commented 3 months ago

The word server seems much to dangerous to me. As we discussed off-line, there is at least one place where that word is already in use as the name of something. Please see https://github.com/valkey-io/valkey/blob/c0a83c00583ed2959079ae34ed8ca4cf7f90a264/tests/support/redis.tcl#L60

zuiderkwast commented 3 months ago

It is actually a client in most cases. :) Maybe it's safer to replace it with valkey... Or we can also leave it as "redis".

madolson commented 3 months ago

I'd vote just replace redis with valkey in the tests.

zuiderkwast commented 2 months ago

@hwware you're assigned to this issue so i'll let you decide about #287. It seems to be overlapping a bit with you pr #283.