search

valkey-io / valkey

A new project to resume development on the formerly open-source Redis project. We're calling it Valkey, since it's a twist on the key-value datastore.
https://valkey.io
Other
14.46k stars 510 forks source link

code cleanup: move printver.tcl into info-command.tcl #219

Open daniel-house opened 2 months ago

daniel-house commented 2 months ago

It seems that https://github.com/valkey-io/valkey/blob/unstable/tests/unit/printver.tcl should be absorbed into https://github.com/valkey-io/valkey/blob/unstable/tests/unit/info-command.tcl

It was created 13 years ago by antirez. Based on the comment

Print version info before running the test

it was created as a development test tool just for the two info-fields redis_version and redis_git_sha1 (which is now server_git_sha1). All it does is check that the fields are present and print their values.

redis_version is already checked in info-command.tcl. redis_git_sha1 and some other fields should be added to info-command.tcl.

enjoy-binbin commented 2 months ago

yean, i think we can remove it, it is indeed should be cover by the info-command.tcl