valkey-io / valkeymodule-rs

Rust valkey SDK for modules
BSD 3-Clause "New" or "Revised" License
35 stars 10 forks source link

Remove RedisEnterpriseCommandFlags for Valkey #17

Closed dmitrypol closed 2 months ago

dmitrypol commented 6 months ago

in commands.rs

#[derive(Debug, Deserialize)]
pub enum RedisEnterpriseCommandFlags {
    /// A special enterprise only flag, make sure the commands marked with this flag will not be expose to
    /// user via `command` command or on slow log.
    ProxyFiltered,
}

impl From<&RedisEnterpriseCommandFlags> for &'static str {
    fn from(value: &RedisEnterpriseCommandFlags) -> Self {
        match value {
            RedisEnterpriseCommandFlags::ProxyFiltered => "_proxy-filtered",
        }
    }
}
dmitrypol commented 6 months ago

@madolson @PingXie - you guys OK with this? I can easily make the change.

PingXie commented 6 months ago

I think we should remove it. The obvious branding issue aside, it also makes no sense to reference an architectural decision (proxy) that is not in the Valkey scope.

madolson commented 6 months ago

I agree, let's remove it