search

valknight / Cohost.py

A python library for Cohost.org!
MIT License
58 stars 8 forks source link

add support for listing asks #34

Closed a-e-m closed 1 year ago

a-e-m commented 1 year ago

Pretty much what it sounds like. The asks endpoint is asks.listPending and it requires an input parameter, which should be a Python dict serialized to JSON. I tried to update fetchTrpc in a way that would work for other calls in the future

valknight commented 1 year ago

thanks for this! this looks rad! would you mind if I made some quick naming changes + typing hints? Specifically, renaming the method to getAsksRaw - this lets an Ask class to be added, without causing an existing method to start returning different data :)

a-e-m commented 1 year ago

@valknight yeah go ahead

valknight commented 1 year ago

rad! the builds seem to be all happy, so i'll get this packaged up into a release. thanks for your work!!