valkriaine / Bouncy

RecyclerView and NestedScrollView with physics-based bouncy overscroll effect
Apache License 2.0
198 stars 18 forks source link

Cant compile due to duplicate string values #15

Closed seanyc4 closed 2 years ago

seanyc4 commented 2 years ago

App wont compile due to duplicate string values:

<?xml version="1.0" encoding="utf-8"?>
<resources>
    <!--<declare-styleable name="BouncyNestedScrollView">
        <attr format="float" name="overscroll_animation_size"/>
        <attr format="float" name="fling_animation_size"/>

        <attr format="integer" name="damping_ratio">
            <enum name="DAMPING_RATIO_NO_BOUNCY" value="0"/>
            <enum name="DAMPING_RATIO_LOW_BOUNCY" value="1"/>
            <enum name="DAMPING_RATIO_MEDIUM_BOUNCY" value="2"/>
            <enum name="DAMPING_RATIO_HIGH_BOUNCY" value="3"/>
        </attr>
        <attr format="integer" name="stiffness">
            <enum name="STIFFNESS_VERY_LOW" value="0"/>
            <enum name="STIFFNESS_LOW" value="1"/>
            <enum name="STIFFNESS_MEDIUM" value="2"/>
            <enum name="STIFFNESS_HIGH" value="3"/>
        </attr>
    </declare-styleable>-->
    <declare-styleable name="BouncyRecyclerView">
        <attr format="float" name="recyclerview_overscroll_animation_size"/>
        <attr format="float" name="recyclerview_fling_animation_size"/>
        <attr format="boolean" name="allow_drag_reorder"/>
        <attr format="boolean" name="allow_item_swipe"/>

        <attr format="integer" name="recyclerview_damping_ratio">
            <enum name="DAMPING_RATIO_NO_BOUNCY" value="0"/>
            <enum name="DAMPING_RATIO_LOW_BOUNCY" value="1"/>
            <enum name="DAMPING_RATIO_MEDIUM_BOUNCY" value="2"/>
            <enum name="DAMPING_RATIO_HIGH_BOUNCY" value="3"/>
        </attr>
        <attr format="integer" name="recyclerview_stiffness">
            <enum name="STIFFNESS_VERY_LOW" value="0"/>
            <enum name="STIFFNESS_LOW" value="1"/>
            <enum name="STIFFNESS_MEDIUM" value="2"/>
            <enum name="STIFFNESS_HIGH" value="3"/>
        </attr>
    </declare-styleable>
</resources>

I had to manually comment out the nestedscrolling values to get it to compile, please fix this.

valkriaine commented 2 years ago

This should be fixed now, please update to the newest version of Bouncy and try again, thank you!

seanyc4 commented 2 years ago

There is still an error on the in the BouncyNestedScroolView. The variable "stiffness" clashes with the Material Design 1.6.0 variable. You will need to rename stiffness to something else like bouncy_stiffness. Causes compile time error and have to comment the code out to make it run

valkriaine commented 2 years ago

Thank you! I will update the library later today

valkriaine commented 2 years ago

resolved in 2.3