valkyriedragon / psxjin

Automatically exported from code.google.com/p/psxjin
0 stars 0 forks source link

CdlGetTD is not emulated correctly #40

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Attempt to play Toy Story 2 (NTSC)

What is the expected output? What do you see instead?
One expects the game to load and play normally, but it instead appears to 
freeze after the rating screen, before the first MDEC intro logo movie plays.

What version of the product are you using? On what operating system?
PSXjin SVN trunk (r722), but replicated on v2.0.2 release as well.

Please provide any additional information below.
This is due to incorrect emulation of the CdlGetTD command. Namely, two things:
* It fails to handle non-CUE-using disc images correctly (due to the use of "= 
0" instead of "== 0" in the if predicate
* It fails to handle track 0 requests, where it should return the end of the 
last track

The attached patch (against current SVN trunk r722) fixes these issues, 
allowing Toy Story 2 to run. I wouldn't be surprised if this fixed other games 
too.

Thanks to crash41596 (twitch.tv/crash41596) for testing the patch!

Original issue reported on code.google.com by tiber...@gmail.com on 6 Aug 2013 at 6:27

Attachments:

GoogleCodeExporter commented 8 years ago
Fixed in r723.

Original comment by tiber...@gmail.com on 24 Oct 2013 at 9:28