search

valkyrnstudios / RankSentinel

MIT License
4 stars 2 forks source link

Temporarily ignore players who just levelled #80

Closed SabreValkyrn closed 1 year ago

SabreValkyrn commented 1 year ago

Add player dings to session cache and ignore further alerts. Small chance to hide actual alerts, but far less irritating to ding and get immediately hit with a bunch of alerts.

Gogo1951 commented 1 year ago

That's why they get a 1-level grace period. =P

SabreValkyrn commented 1 year ago

Not sure I follow that comment. Given someone can't be level 81 in Wrath, dinging level 80 inside a dungeon results in immediate spam.

Another scenario, if a level 76 gets alerted for level 74 spells, then dings 77 in a dungeon, they get alerted for those same level 74 spells.

Gogo1951 commented 1 year ago

I've leveled 6 toons through dungeon grinding PUGs with RankSentinel on.

Yes, when someone hits 80 they get spammed.

But I have yet to have anyone complain about it.

Everyone I've come across... dozens of people have hit 80 in a group with me... "Oh man, thanks for the reminder. I need to go train!" or "Man, there's a lot of stuff to train!" One time I got asked, "Since you care, wanna spot me the gold to train?" That last one was about as negative as I've gotten. (=

Failing to report it passes the buck to the next group to report... no telling when that will be. And also... candidly reporting en masse is still a good opportunity to for people to learn about the add-on. Most people who get hit with a bunch of useful reminders think, "Cool, I should get that add-on too so I can help my friends.... and also these random cunts I hate in PUGs... to improve. Because I'm better than them." Ha. Paraphrased.

Gogo1951 commented 1 year ago

Hmm... the not hitting someone twice for the same infraction though. That may be valid. Like if we already reminded them about Heroic Strike, and they level, and we remind them about Heroic Strike again... yeah that's annoying.

How about just only remind for one ability group (Heroic Strike) per session per toon, regardless of level change? I think that works. Just add a check, "Have I already hit him about Heroic Strike this instance?"

SabreValkyrn commented 1 year ago

One AbilityGroup notification per session is elegant, I was going to look for a previous spell index from an earlier level.