valkyrnstudios / RankSentinel

MIT License
4 stars 2 forks source link

Low rank Penance not being detected #82

Closed trey-k closed 9 months ago

trey-k commented 1 year ago

Didn't have any notifications/whispers during raid to our priest but logs show a rank 1 Penance being used, tested with the priest in party and no detection occurred shuffling through every rank. Spell ID for rank 1 in logs is listed as 47750

SabreValkyrn commented 1 year ago

HM. Talented abilities have been a pain.

Penance Rank 1 in current data is 47540

Priest Penance 60 1 47540
Priest Penance 70 2 53005
Priest Penance 75 3 53006
Priest Penance 80 4 53007
Gogo1951 commented 1 year ago

I don't see Penance as being 47750.

https://wotlkdb.com/?spell=47540 https://www.wowhead.com/wotlk/spell=47540/penance

What I think shows is both numbers in the log. One for cast, and one for each "tick" of the heal.

As long as we track 1, it'll notify correctly. I'll test it later on my priest.

SabreValkyrn commented 1 year ago

Awesome, thanks. I don't have a Priest at all to check this with

Gogo1951 commented 1 year ago

image image image image

But... I don't get an alert when Rank 1 is cast.

Gogo1951 commented 1 year ago

Spell in combat log seems to line up too.

image

Gogo1951 commented 1 year ago

Healing IDs

Original

Priest Penance 60 1 47540 Priest Penance 70 2 53005 Priest Penance 75 3 53006 Priest Penance 80 4 53007

In-Game Wrath 2023

Priest Penance 60 1 47750 Priest Penance 70 2 52983 Priest Penance 75 3 52984 Priest Penance 80 4 52985

Damage IDs

No IDs shown... odd.