search

valkyrnstudios / RankSentinel

MIT License
4 stars 3 forks source link

Whitelist Frost Nova (Rank 1) - mage #88

Closed linkx2252 closed 2 months ago

linkx2252 commented 9 months ago

Most rages run r1 frost nova forever because of the mana cost - recommend white listing this from the addon.

SabreValkyrn commented 9 months ago

Where? Classic? SoD? Wrath?

linkx2252 commented 9 months ago

Sorry, this is for SoD and classic/era.

On Thu, Feb 15, 2024 at 7:01 PM SabreValkyrn @.***> wrote:

Where? Classic? SoD? Wrath?

— Reply to this email directly, view it on GitHub https://github.com/valkyrnstudios/RankSentinel/issues/88#issuecomment-1947529894, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARV2K7KGE5DVMKV5R6NYCFLYT2OTXAVCNFSM6AAAAABDK7ENO6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBXGUZDSOBZGQ . You are receiving this because you authored the thread.Message ID: @.***>

SabreValkyrn commented 9 months ago

Hm, frost nova r1 is indeed not excluded for Classic.

Rain of Fire r1 is though.

Gogo1951 commented 7 months ago

If it were up to me it would spam every Mage casting Frost Nova in PVE and be like, "Hey idiot, stop making it harder for your tank to gather things up." =P

This is the single biggest annoying issue to tank through. Mages deciding where you have to stop pulling by casting Frost Nova... usually in the wrong spot so a healer gets hit. =P

Ha.

But Rank 1 is semi-legit for PVE. =P

Ok, I'm out again. Cheers!

axlroden commented 4 months ago

exactly, rank 1 frost nova in any classic variant cost less mana, so should be the only spell mages cast. Since classic and wrath have different spell libraries, it should be an easy fix.. line 1117

Gogo1951 commented 2 months ago

Nova 1 is the only spell I've seen that likely should be whitelisted. It'd be good to make this fix.

SabreValkyrn commented 2 months ago

Removed in latest release, sorry I suck and took 5ever. :/