Open avportal opened 4 years ago
Hi @avportal. I'm very sorry it took this long to get back to you fully. It seems that you are correct about the modes package. We only use one function from there (shown below). It shouldn't be to hard to port it over, and remove the modes as a dependency completely. I will work on this tomorrow and try to get the changes update for you.
bimodality_coefficient<-function(x, finite=TRUE,...){
if(finite==TRUE){
G=skewness(x,finite)
sample.excess.kurtosis=kurtosis(x,finite)
K=sample.excess.kurtosis
n=length(x)
B=((G^2)+1)/(K+ ((3*((n-1)^2))/((n-2)*(n-3))))
}
else{
G=skewness(x,FALSE)
K=kurtosis(x,FALSE)
B=((G^2)+1)/(K)
}
return(B)
}
@grabear I created this little branch for that. Feel free to delete it. 😃
Thank you!
Cheers,
Angel
On 08 Jul 2020, at 01:12, Rob Gilmore notifications@github.com wrote:
Hi @avportal https://github.com/avportal. I'm very sorry it took this long to get back to you fully. It seems that you are correct about the modes package. We only use one function from there (shown below). It shouldn't be to hard to port it over, and remove the modes as a dependency completely. I will work on this tomorrow and try to get the changes update for you.
bimodality_coefficient<-function(x, finite=TRUE,...){ if(finite==TRUE){ G=skewness(x,finite) sample.excess.kurtosis=kurtosis(x,finite) K=sample.excess.kurtosis n=length(x) B=((G^2)+1)/(K+ ((3((n-1)^2))/((n-2)(n-3)))) } else{ G=skewness(x,FALSE) K=kurtosis(x,FALSE) B=((G^2)+1)/(K) } return(B) } — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/vallenderlab/MicrobiomeR/issues/105#issuecomment-655185856, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO4MKESZJR3YC3PALALNWILR2OTWZANCNFSM4N5LG6UQ.
Angel Valverde Portal IRNASA-CSIC C/ Cordel de Merinas 40-52 37008 Salamanca Spain Tel.: +34 923 219 606
@avportal I would suggest installing this release with the latest version of R (4.0).
install.packages("MicrobiomeR_0.7.0.tar.gz", repos = NULL, type ="source")
Many thanks.
Regards,
Angel
On 09 Aug 2020, at 05:21, Shaurita Hutchins notifications@github.com wrote:
@avportal https://github.com/avportal I would suggest installing this release https://github.com/vallenderlab/MicrobiomeR/releases/tag/v0.7.0 with the latest version of R (4.0).
MicrobiomeR_0.7.0.tar.gz https://github.com/vallenderlab/MicrobiomeR/files/5046711/MicrobiomeR_0.7.0.tar.gz install.packages("MicrobiomeR_0.7.0.tar.gz", repos = NULL, type =‘‘source’’) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/vallenderlab/MicrobiomeR/issues/105#issuecomment-671000458, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO4MKETVGLKCPZ3O7HXNHVDR7YI3XANCNFSM4N5LG6UQ.
Angel Valverde Portal IRNASA-CSIC C/ Cordel de Merinas 40-52 37008 Salamanca Spain
Tel.: +34 923 219 606 (Ext. 231) Fax: +34 923 219 609 angel.valverde@csic.es
work around: download modes package from CRAN: https://cran.r-project.org/web/packages/modes/index.html, and install it locally install_local()
@lixiaopi1985 Thank you for this workaround. @sdhutchins And thank you for pushing a working release.
@avportal The issue should be fixed by installing MicrobiomeR using @sdhutchins solution. If you have any more issues with this, then please let us know.
The primary reason for the delay with this bug fix was a failure to get our Travis CI and GitHub actions working properly. However, this is a separate issue and should have been treated as one.
It did work indeed. Thanks!
Cheers,
Angel
El 5 oct 2020, a las 17:32, Rob Gilmore notifications@github.com escribió:
@lixiaopi1985 https://github.com/lixiaopi1985 Thank you for this workaround. @sdhutchins https://github.com/sdhutchins And thank you for pushing a working release.
@avportal https://github.com/avportal The issue should be fixed by installing MicrobiomeR using @sdhutchins https://github.com/sdhutchins solution. If you have any more issues with this, then please let us know.
The primary reason for the delay with this bug fix was a failure to get our Travis CI and GitHub actions working properly. However, this is a separate issue and should have been treated as one.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/vallenderlab/MicrobiomeR/issues/105#issuecomment-703709571, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO4MKERMZYCFHK2VDSYGIOLSJHRJ3ANCNFSM4N5LG6UQ.
Angel Valverde Portal IRNASA-CSIC C/ Cordel de Merinas 40-52 37008 Salamanca Spain
Tel.: +34 923 219 606 (Ext. 231) Fax: +34 923 219 609 angel.valverde@csic.es
Hi there,
I am trying to install the package but I get the following error message:
It seems that the package "modes" has been removed from the CRAN repository.
Insert Session info here