Fix #N/A - Githubissues

vallettea / koala

Transpose your Excel calculations into python for better performances and scaling.

GNU General Public License v3.0

144 stars 59 forks source link

Fix #N/A #136

Closed altosz closed 6 years ago

altosz commented 6 years ago

@vallettea Fixed bug: #N/A values in Excel are treated as 0 value.

Given:

cell A1 in Excel has value '#N/A'
cell B1 in Excel has formula '=A1*5'

In Excel B1 is evaluated to '#N/A'. In koala B1 is evaluated to 0.

PS: I also fix some pep8 warning in files/lines that I touch.

altosz commented 6 years ago

@vallettea any comments? does the proposed solution fit the general flow?

vallettea commented 6 years ago

sorry for the late response, I'm on holidays. Thanks for this work. Can you just increment the version number in package.json so I can publish it on pypi

altosz commented 6 years ago

I have incremented version number in setup.py https://github.com/anthill/koala/pull/136/files#diff-2eeaed663bd0d25b7e608891384b7298R10

Did not find any package.json. @vallettea

vallettea commented 6 years ago

sorry about package.json (I did too much nodejs these days). Perfect, pushing it now.

altosz commented 6 years ago

Thanks, @vallettea Have a nice vacation