search

vallettea / koala

Transpose your Excel calculations into python for better performances and scaling.
GNU General Public License v3.0
144 stars 59 forks source link

Fix resolve range #184

Closed danielsjf closed 5 years ago

danielsjf commented 5 years ago

This pull request solves two types of issues:

Both issues are solved by adding the empty cells to the graph when they occur in a range. For row or column style ranges, only empty cells within the sheet dimension are added. For instance, if A5 is the lowest row and E1 is the furthest column, the sheet dimensions are E (5), 5. A range 3:3 would be evaluated as (A3, B3, C3, D3, E3).

The test won't pass until the other pull requests are merged.

danielsjf commented 5 years ago

72 might be solved after this, but the issue lacks details on the exact problem.

danielsjf commented 5 years ago

Apparently the tests do not automatically rerun after another merge so a small edit should do the trick to rerun the tests.

vallettea commented 5 years ago

@danielsjf thanks for you work. Normally the tests should run after each commit.

danielsjf commented 5 years ago

@valletea, thanks. All five pull requests are ready to merge.

brianmay commented 5 years ago

Test failures need addressing...

danielsjf commented 5 years ago

Moving to #186 in favour of this one.