search

vallettea / koala

Transpose your Excel calculations into python for better performances and scaling.
GNU General Public License v3.0
143 stars 60 forks source link

bugfix gen_graph #215

Closed Brad-eki closed 5 years ago

Brad-eki commented 5 years ago

Fixing gen_graph as per #188 and #214.

danielsjf commented 5 years ago

@vallettea, somehow the tests do not run anymore on Travis. Is this related in any way to your team not supporting this project anymore? If so we should find an alternative.

brianmay commented 5 years ago

Travis tests are at https://travis-ci.org/vallettea/koala - some reason github has a reference to https://travis-ci.org/anthill/koala/ which doesn't exist anymore. I am getting a bit confused at this point

danielsjf commented 5 years ago

@Brad-eki actually I see that one test fails. Could you have a look before merging? (see comment @brianmay for the correct version of the test).

Brad-eki commented 5 years ago

@brianmay, @danielsjf - it looks like the anthill isn't interested in Koala anymore. It seems @vallettea has moved ownership of Koala.

Brad-eki commented 5 years ago

@danielsjf sure.

Brad-eki commented 5 years ago

I'm having trouble with Git tonight. Something odd has happened WRT my e-mail address becoming crossed over so now I can't commit. I'm not in Europe and so the hour is getting late.

I had made some changes with respect to anthill/vallettea and the requirements/setup.py re-alignment to put forward as well.

I'm hoping to have these few things sorted by the other side of the weekend or early next week.

If anyone decides it needs to happen quicker, please take the liberty.

Next up I intend to take an approach similar to @danielsjf has taken in Spreadsheet and go through the AST code to bring it into some variety of order; where things are in named methods, potentially have more meaningful variable names, explain or remove the "does anyone know what this is?" kind of code. Not expecting to change much code, just put it in a form which is (maybe) easier to follow.

After this I expect to put effort into our tests.

danielsjf commented 5 years ago

@brad-eki, perfect for me. I don't have any urgent needs for the changes. I already noticed the offset in requirements after installing it with a colleague, but I formalised it in an issue.

Brad-eki commented 5 years ago

I'll have to have another attempt at change.

vallettea commented 5 years ago

I removed all reference to anthill, hope it will fix travis.