Merging fix of Spreadsheet/ExcelCompiler, updated tests, Attempt 4 - Githubissues

vallettea / koala

Transpose your Excel calculations into python for better performances and scaling.

GNU General Public License v3.0

147 stars 59 forks source link

Merging fix of Spreadsheet/ExcelCompiler, updated tests, Attempt 4 #225

Closed bradbase closed 5 years ago

bradbase commented 5 years ago

Moved ExcelCompiler functionality to spreadsheet, keeping backwards compatibility for ExcelCompiler
Added a second constructor to Spreadsheet to support the ability to create a Spreadsheet object with the newly acquired functionality
Added a third constrictor called build_spreadsheet which is essentially a helper, running gen_graph() on your behalf
re-named self.Range to self.range
supported the Spreadsheet object move to cell_XXX method names
some bug fixes based on testing utils.py
updated requirements.txt
updated setup.py
fixed test_basic_evaluation to use the new cell_XXX methods for Spreadsheet object.
fixed test_pruning to use the new cell_XXX methods for Spreadsheet object.
fixed test_excel to use the new cell_XXX methods for Spreadsheet object.
fixed test_spreadsheet to use the new cell_XXX methods for Spreadsheet object.
added many tests, and fixed test_utils
bug fixed ast.init.py graph_from_seeds to generate the graph regardless of being called from a Spreadsheet object or an ExcelCompiler object.

bradbase commented 5 years ago

Merging ExcelCompiler with Spreadsheet to remove ExcelCompiler can't be done simply.

If you keep fixing things you find it eventually breaks this operation which requires the cellmap to expand when you try and get the range, but doesn't currently due to the design of RangeCore and its interaction with Spreadsheet:

 # Extracting Ranges (from existing Cells)
 r_range = sp.range('Sheet1!R1:R4')
 print('Created Range from R column', r_range.values)