Closed bradbase closed 4 years ago
@bradbase This fix looks good if it fixes your issues. The Python 3.4 issues seems more of a glitch in the tests than a fundamental error. I've had it too in the past and it disappeared by itself. I'm not really sure what the origin is.
The move to the new ast is nice. The location of that code always bothered me :-)
Regarding the tests, there are a few things that disappear:
So if I understand it well, with this PR, there is no need to roll back the previous fixes?
@Brad-eki, @bradbase, if we can clear out the last remaining points we can merge this one. Since it is quite a big PR, it might be a shame to loose track due to future other PRs that modify similar parts. For instance #236 also interacts with astnodes might also need to be integrated in this one.
This approach can't work.
Python 3.4... gotta make that work.