search

vallis / libstempo

libstempo — a Python wrapper for tempo2
MIT License
29 stars 34 forks source link

add NE_SW parameter to the designmatrix #71

Closed siyuan-chen closed 3 months ago

siyuan-chen commented 3 months ago

This is the second PR related to adding tempo2 functionality to libstempo, so that the IPTA DR3 combination can be correctly analyzed with libstempo and enterprise.

The NE_SW parameter defining the average density of electrons from the spherical solar wind model is added to the designmatrix as a fully working parameter, that can be fixed (flag value 0), fitted (flag value 1) and marginalized for the data analysis.

E.g in the par file: NE_SW 7.9 0 or NE_SW 7.9 1

siyuan-chen commented 3 months ago

Hi @mattpitkin , this is the other PR merge into libstempo, so that the NE_SW parameter is properly taken into account. This PR should be fine as I just added parameters and variables that are passed through libstempo. If it looks fine to you, feel free to merge. I want to ask some of the testers of the other PR whether things work fine for them, before we merge that as well. Thanks for your help.

mattpitkin commented 3 months ago

Looks good to me. I'm happy to merge this in.