search

valnet / valuenetwork

Resource Planning and Value Accounting for Value Networks
http://mikorizal.org
GNU Affero General Public License v3.0
99 stars 25 forks source link

Is_context is in wrong place on Agent Type #333

Closed fosterlynn closed 8 years ago

fosterlynn commented 9 years ago

Designating whether a type of agent is a context agent or not works fine for Sensorica, since all networks are internal. But this may not work for GNLU very well. And thinking about it, it is not really the correct place from a modeling standpoint because the type of agent is not related to whether it is a context agent in any installation which comprises a network or group of related networks.

fosterlynn commented 9 years ago

Working in valdev on Sensorica value equations, we created an Agent Type of Exchange Firm so we could make those into context agents. Again the same problem - conceptually, exchange firm is a agent association role, not an agent type.

I think more strongly that we should pull back the Agent Type into actually different types irrespective of roles they play. Like Person and Organization are recognizable as different things by themselves. Likewise if we ever support bots as agents, these are different things.

We could leave the context agent flag on Agent Type and just override it on Agent, which would make for an easier transition.

fosterlynn commented 8 years ago

I'm fixing this while I work on exchange types, transfers, etc. Adding is_context to agent, leaving on agent type.

fosterlynn commented 8 years ago

Change made. Need to run conversion when deployed.