password reset bug

[bhaugen]

It's not finding the email address.

This is in that Pinax Account app. It's looking at its own email field, not the user or agent email fields.

I think that used to work, but we broke the connection somewhere along the line.

Two possible fixes:

1. Find out where we broke the connection (where the Account email was being set) and fix that, or
2. Take control of the Account app ourselves and change it.

[bhaugen]

Looking at the Account code. Looks like when a new User is saved, Account has a post_save signal handler that creates a new Account with the same email address as the User.email. However, if the User is created without an email address, then the Account will also have no email address. And if the User gets an email address later, the Account will not be updated.

So the cleanest change would be to take control of the Account app and have it check for the User and Agent email addresses as well as its own email address.

To take control of the Account app, we could fork it or make it internal (copy and paste into the valuenetwork code).

Overall problem: too many email addresses in too many places.

[bhaugen]

Forking will be cranky. We depend on an early version, the project has moved on. More practical to internalize, at least for now.

[bhaugen]

This is a relatively rare problem.

• Of Sensorica's 109 users, only 4 lack account EmailAddresses.
• In commons, it's 14 of 23, 4 of which have User.emails.

[bhaugen]

This has been fixed, but has not yet been deployed to Sensorica's instance. [Now deployed]

I internalized both django-user-accounts and pinax-utils. The first is the account app, which I internalized to fix the password reset problem, and pinax-utils was a related dependency that was breaking in new installations.