search

valnet / valuenetwork

Resource Planning and Value Accounting for Value Networks
http://mikorizal.org
GNU Affero General Public License v3.0
99 stars 25 forks source link

Show most active projects on the homepage. #502 #507

Closed cillian closed 8 years ago

cillian commented 8 years ago

This adds most active projects to the homepage. It adds them in a 4th column, not 100% sure if that's the best way yet.

bhaugen commented 8 years ago

Got a screenshot? If so, show it here, we can get some feedback.

Also: did you look at the HomePageLayout model?

It's a cheap hacky way of making a configurable front page. The data-driven panels can be selected for use or not, or replaced by HTML text panels. That's also where we settled on 3 columns, which is a little rigid.

It adds them in a 4th column, not 100% sure if that's the best way yet.

Yeah, me either. And I'm also not sure it is a good idea to continue with that rigid format of a fixed number of panels. So I'm also pretty sure it is not a good idea to change the model, go thru schema migrations, etc, just extending the same idea.

What would it take to make the column spans vary depending on the number of panels selected for use? So if they select only two of the panels, then the 3rd column wold be the most active projects?

Let me know it this is not understandable or doesn't make sense to you to do.

TiberiusB commented 8 years ago

Waw, this is a feature I was looking for for long time. I am eager to see how it looks. On Jun 24, 2016 5:31 PM, "Bob Haugen" notifications@github.com wrote:

Got a screenshot? If so, show it here, we can get some feedback.

Also: did you look at the HomePageLayout model https://github.com/valnet/valuenetwork/blob/master/valuenetwork/valueaccounting/models.py#L131 ?

It's a cheap hacky way of making a configurable front page. The data-driven panels can be selected for use or not, or replaced by HTML text panels. That's also where we settled on 3 columns, which is a little rigid.

It adds them in a 4th column, not 100% sure if that's the best way yet.

Yeah, me either. And I'm also not sure it is a good idea to continue with that rigid format of a fixed number of panels. So I'm also pretty sure it is not a good idea to change the model, go thru schema migrations, etc, just extending the same idea.

What would it take to make the column spans vary depending on the number of panels selected for use? So if they select only two of the panels, then the 3rd column wold be the most active projects?

Let me know it this is not understandable or doesn't make sense to you to do.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/valnet/valuenetwork/pull/507#issuecomment-228466968, or mute the thread https://github.com/notifications/unsubscribe/ADu2SQgTgEMyyYH5HILYW6_ppWcaX8IRks5qPEybgaJpZM4I-GzD .

bhaugen commented 8 years ago

Hi @cillian - where are you at on this? Did my suggestions for improvement make sense to you? If so, got time to do them? If you think they make sense but you don't have time, let me know and I'll merge your PR anyway and then raise an issue for the improvements and Tibi can see how it looks.

cillian commented 8 years ago

Hi @bhaugen yes that makes sense for the panels to expand to fill the available space depending on what's enabled. It should behave like that now. The active projects panel is pretty basic, it just shows projects with activity in the last 6 months.

panels

bhaugen commented 8 years ago

Thanks a lot! Merging.