Open jokull opened 3 years ago
BTW thank you for creating this. Super useful for my tiny project. In development I'm transparently letting requests pass through to my frontend development server. In production I also use the proxy to serve the static build. The frontend is using Svelte Kit. It's a super lean and quick way to have both Python and Svelte JS in the same repo. On Render I deploy using
NODE_ENV=production poetry install --no-dev && pip install gunicorn && yarn install --production=false && node_modules/.bin/svelte-kit build
and then just run gunicorn with a uvicorn worker.
Thank you for the appreciation and sorry it's taken a while to get back to this.
I wonder if there should be other upstream headers that should be deduplicated by default – HTTP of course supports multiple headers, and in many cases (e.g. Set-Cookie
) they should be kept as-is...
I noticed a URL queryparameter like
?import
is turned into?import=
. Perhaps it's better to pass thescope['query_string']
along naively to ensure URL’s are as transparent and unmodified as possible?... also noticed a double date header because my server added it. Perhaps a default behaviour of removing it from the upstream response headers?