valohai / django-allauth-2fa

Two-factor authentication for Django Allauth
Other
212 stars 51 forks source link

Add support for overriding forms #161

Closed monosans closed 1 year ago

monosans commented 1 year ago

Such a setting exists in allauth. I miss it very much here.

valberg commented 1 year ago

Hey @monosans!

Good idea! Can you add some tests to make sure that we are not breaking anything (now and in the future).

akx commented 1 year ago

I'm a tiny bit on the fence about this – on one hand, in the spirit of avoiding There's More Than One Way To Do It, I'd just say you should derive the views in your app with a custom form_class, but since allauth already does this, it makes sense to follow the same thing here 🙂