search

valohai / django-allauth-2fa

Two-factor authentication for Django Allauth
Other
212 stars 51 forks source link

Add flag and logic to removal form to make otp for device removal optional #172

Closed jkaeske closed 12 months ago

jkaeske commented 12 months ago

I tried to implement the feature specified in #169. I also wrote a test for the device removal with and without required otp.

Would be nice to get a review on that :)

codecov-commenter commented 12 months ago

Codecov Report

Merging #172 (04c5c84) into main (4b515a8) will increase coverage by 0.11%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #172      +/-   ##
==========================================
+ Coverage   92.64%   92.76%   +0.11%     
==========================================
  Files          15       15              
  Lines         544      553       +9     
==========================================
+ Hits          504      513       +9     
  Misses         40       40
Impacted Files Coverage Δ
allauth_2fa/app_settings.py 100.00% <100.00%> (ø)
allauth_2fa/forms.py 93.84% <100.00%> (+0.29%) :arrow_up:
tests/test_allauth_2fa.py 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

jkaeske commented 12 months ago

That's done @akx

valberg commented 12 months ago

Great work @jkaeske!

valberg commented 12 months ago

@jkaeske Can you do an update to CHANGELOG.md as well?

jkaeske commented 12 months ago

I did that and created a pull request