search

valohai / django-allauth-2fa

Two-factor authentication for Django Allauth
Other
212 stars 51 forks source link

Include new feature from issue #169 in changelog #173

Closed jkaeske closed 12 months ago

jkaeske commented 12 months ago

Here is the updated changelog @valberg :)

akx commented 12 months ago

@jkaeske Please rebase this on top of valohai/main so there's just one commit left :)

valberg commented 12 months ago

We can just squash it

akx commented 12 months ago

@valberg Technically yeah – but knowing how to rebase is also a good learning experience 😁

(If you decide to squash-merge, please clean up the commit message (which AFAIU can't be done on GitHub Mobile)).

valberg commented 12 months ago

Hmm Github mobile says it would add 5 commits if squashing - so nvm me

jkaeske commented 12 months ago

I think that worked, maybe? 😅

akx commented 12 months ago

@jkaeske Yep, it did! Thanks :)

jkaeske commented 12 months ago

Thanks to you @akx @valberg , for your help! :)