search

valohai / django-allauth-2fa

Two-factor authentication for Django Allauth
Other
212 stars 51 forks source link

Templates are not included in 0.11.0 wheel distribution #176

Closed apagano-vue closed 11 months ago

apagano-vue commented 11 months ago

We upgraded to v.0.11.0 and started seeing some TemplateDoesNotExist errors in our staging env. After some troubleshooting it seems that the html template are missing in the wheel distribution of the release. This completely breaks the package.

Version 0.10.0 manually downloaded from PyPi: 

$ unzip -l django_allauth_2fa-0.10.0-py3-none-any.whl 
Archive:  django_allauth_2fa-0.10.0-py3-none-any.whl
  Length      Date    Time    Name
---------  ---------- -----   ----
       23  2022-07-04 11:28   allauth_2fa/__init__.py
     1474  2022-07-04 11:28   allauth_2fa/adapter.py
      321  2022-07-04 11:28   allauth_2fa/app_settings.py
     2952  2022-07-04 11:28   allauth_2fa/forms.py
     4049  2022-07-04 11:28   allauth_2fa/middleware.py
      728  2022-07-04 11:28   allauth_2fa/mixins.py
      633  2022-07-04 11:28   allauth_2fa/urls.py
     1084  2022-07-04 11:28   allauth_2fa/utils.py
     6776  2022-07-04 11:28   allauth_2fa/views.py
      340  2022-07-04 11:28   allauth_2fa/templates/allauth_2fa/authenticate.html
      770  2022-07-04 11:28   allauth_2fa/templates/allauth_2fa/backup_tokens.html
      391  2022-07-04 11:28   allauth_2fa/templates/allauth_2fa/remove.html
      621  2022-07-04 11:28   allauth_2fa/templates/allauth_2fa/setup.html
      625  2022-07-04 11:29   django_allauth_2fa-0.10.0.dist-info/LICENSE
     4944  2022-07-04 11:29   django_allauth_2fa-0.10.0.dist-info/METADATA
       92  2022-07-04 11:29   django_allauth_2fa-0.10.0.dist-info/WHEEL
       12  2022-07-04 11:29   django_allauth_2fa-0.10.0.dist-info/top_level.txt
     1566  2022-07-04 11:29   django_allauth_2fa-0.10.0.dist-info/RECORD
---------                     -------
    27401                     18 files

Version 0.11.0 manually downloaded from PyPi: 

$ unzip -l django_allauth_2fa-0.11.0-py3-none-any.whl 
Archive:  django_allauth_2fa-0.11.0-py3-none-any.whl
  Length      Date    Time    Name
---------  ---------- -----   ----
       59  2020-02-02 00:00   allauth_2fa/__init__.py
     4103  2020-02-02 00:00   allauth_2fa/adapter.py
      643  2020-02-02 00:00   allauth_2fa/app_settings.py
     3305  2020-02-02 00:00   allauth_2fa/forms.py
     4354  2020-02-02 00:00   allauth_2fa/middleware.py
      882  2020-02-02 00:00   allauth_2fa/mixins.py
      594  2020-02-02 00:00   allauth_2fa/urls.py
      993  2020-02-02 00:00   allauth_2fa/utils.py
     7244  2020-02-02 00:00   allauth_2fa/views.py
     4870  2020-02-02 00:00   django_allauth_2fa-0.11.0.dist-info/METADATA
       87  2020-02-02 00:00   django_allauth_2fa-0.11.0.dist-info/WHEEL
      625  2020-02-02 00:00   django_allauth_2fa-0.11.0.dist-info/licenses/LICENSE
     1054  2020-02-02 00:00   django_allauth_2fa-0.11.0.dist-info/RECORD
---------                     -------
    28813                     13 files
valberg commented 11 months ago

Thank you for the report @apagano-vue! I've found the issue and created a PR with a fix. We will hopefully have a new release out soon!