search

valohai / valohai-cli

:heavy_dollar_sign: Command line client for Valohai
MIT License
14 stars 8 forks source link

Keep create_adhoc_commit_from_tarball in tact #202

Closed magdapoppins closed 2 years ago

magdapoppins commented 2 years ago

Since create_adhoc_commit_from_tarball is being used in jupyhai which isn't aware of custom yaml paths per command, only make yaml_path mandatory in the following private _upload_commit_code function and use the project settings yaml as default.

(Also came across a comment to delete a compatibility alias in 2020 so I did.)

Fixes #194

codecov[bot] commented 2 years ago

Codecov Report

Merging #202 (528b11a) into master (b21e4c0) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #202   +/-   ##
=======================================
  Coverage   85.89%   85.89%           
=======================================
  Files         111      111           
  Lines        3736     3736           
  Branches      631      631           
=======================================
  Hits         3209     3209           
  Misses        367      367           
  Partials      160      160
Impacted Files Coverage Δ
valohai_cli/adhoc.py 82.81% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b21e4c0...528b11a. Read the comment docs.