valohai / valohai-cli

:heavy_dollar_sign: Command line client for Valohai
MIT License
14 stars 8 forks source link

Honour --yaml flag to parse configuration in vh pipeline run --adhoc #281

Closed hylje closed 1 year ago

hylje commented 1 year ago

Resolves https://github.com/valohai/roi/issues/5071.

During vh pipeline run <pipeline> --adhoc, pipeline steps were resolved on CLI end without honouring the --yaml flag for custom configuration. Project default configuration file's steps were used always. We shall now honour the flag.

This behaviour has an existing test case and the tested code raised an exception as it did not find the default configuration file. However, the default test runner catches exceptions and the test case did not check that the command finished with a successful exit code, nor expected enough output to determine success. These oversights allowed the test to succeed. We will now reraise any exceptions raised during command tests, and pipeline tests will positively assert success up to the API response.

Valohai backend works as expected with CLI initialising its pipeline creation API call using custom configuration.

codecov[bot] commented 1 year ago

Codecov Report

Merging #281 (603934b) into master (028881f) will increase coverage by 0.02%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #281      +/-   ##
==========================================
+ Coverage   86.64%   86.67%   +0.02%     
==========================================
  Files         125      125              
  Lines        4187     4194       +7     
  Branches      639      639              
==========================================
+ Hits         3628     3635       +7     
  Misses        384      384              
  Partials      175      175              
Files Changed Coverage Δ
tests/commands/pipeline/test_run.py 100.00% <100.00%> (ø)
tests/conftest.py 100.00% <100.00%> (ø)
valohai_cli/commands/pipeline/run/run.py 93.61% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more