valohai / valohai-cli

:heavy_dollar_sign: Command line client for Valohai
MIT License
14 stars 8 forks source link

Allow using lists for pipeline parameters form the CLI #300

Closed noorula closed 5 months ago

noorula commented 10 months ago

I have a list type parameter

    parameters:
        - name: dataset_names
          default: [all_harbors]
          type: string
          multiple: separate
          multiple-separator: ','
          optional: false

and I want to use pipeline parameter to assign its values.

- pipeline:
    name: training-pipeline
    parameters:
      - name: dataset
        targets:
          - preprocess.parameter.dataset_names
        default: [all_harbors, harbor_A]

If I commit the code and run in the UI it works fine but for adhoc runs I get this error on the CLI:

API Error:
parameters:
  dataset:
    expression:
      * Incorrect pipeline parameter. Expected ParameterExpression, string, int, float, or bool but got ['all_harbors', 'harborA'] (code: invalid)
SofiaChar commented 5 months ago

Great timing! Dynamic Pipelines demo was published as an example. Ionpath would really like to use Pipeline Tasks not only from the UI, but also through cli.

hylje commented 5 months ago

Pipeline tasks CLI is a separate feature from this