valohai / valohai-cli

:heavy_dollar_sign: Command line client for Valohai
MIT License
14 stars 8 forks source link

Add command line parameter for runtime config preset #305

Closed teroyks closed 10 months ago

teroyks commented 10 months ago

Resolves #303

Allow setting a preset ID with the --k8s-preset command line option.

Note: preset slug support will be automatic once that has been added to the API – no functional changes required (though the help text should be updated).

Note: The first commit contains all the functional changes in this PR – the rest are just refactoring and tidying up the code a bit. Especially the last one is things that are more a matter of taste (and can be reverted easily).

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f718b90) 86.72% compared to head (0b13f6d) 86.85%. Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #305 +/- ## ========================================== + Coverage 86.72% 86.85% +0.12% ========================================== Files 126 126 Lines 4362 4374 +12 Branches 907 903 -4 ========================================== + Hits 3783 3799 +16 + Misses 396 394 -2 + Partials 183 181 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.