search

valohai / valohai-cli

:heavy_dollar_sign: Command line client for Valohai
MIT License
14 stars 8 forks source link

Use `uv` for dependencies if installed #306

Closed teroyks closed 8 months ago

teroyks commented 8 months ago

Install and update dependencies with uv, fall back to regular pip. Both work if virtual environment was created with venv or virtualenv.

Add requirement for an active virtual environment before installing packages to prevent accidentally updating a global Python installation.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.85%. Comparing base (8c09e3e) to head (e5e3c24).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #306 +/- ## ======================================= Coverage 86.85% 86.85% ======================================= Files 126 126 Lines 4374 4374 Branches 903 903 ======================================= Hits 3799 3799 Misses 394 394 Partials 181 181 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

teroyks commented 8 months ago

Not sure if we really want to add the virtual environment requirement. Personally, I think it would be a good thing to have, but YMMV so up for comments!